Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: Set lower bound of PyYAML v6.0 #400

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Jul 19, 2023

Resolves #399

Environment isolated builds of PyYAML v5.X are broken by Cython v3.0 (c.f. yaml/pyyaml#724). As this will not be patched the only reasonable approach forward is to set a new lower bound of PyYAML v6.0.

A patch release of reana-commons will be needed following this PR to unbreak the rest of the reana ecosystem.

* Environment isolated builds of PyYAML v5.X are broken by Cython v3.0.
  As this will not be patched the only reasonable approach forward is to
  set a new lower bound of PyYAML v6.0.
@matthewfeickert
Copy link
Contributor Author

@tiborsimko @mvidalgarcia This is ready for review. Please let me know if you have any questions.

@codecov-commenter
Copy link

Codecov Report

Merging #400 (8fa8e86) into master (2a61fff) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   34.74%   34.74%           
=======================================
  Files          26       26           
  Lines        1537     1537           
=======================================
  Hits          534      534           
  Misses       1003     1003           

@matthewfeickert
Copy link
Contributor Author

Closing in favor of PR #401

@matthewfeickert matthewfeickert mentioned this pull request Jul 19, 2023
@matthewfeickert matthewfeickert deleted the build/remove-pyyaml-upper-bound branch July 20, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recheck if upper bound on PyYAML is needed
2 participants