Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): add support for Python 3.13 (#732) #732

Merged

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Oct 9, 2024

Closes reanahub/reana#837

Add support for Python 3.13.

Replaced cgi.parse_headers with email.message.Message as recommended in https://peps.python.org/pep-0594/#cgi. Added test to make sure it does the same things that the previous code did. Also tested as in #490.

@jlemesh
Copy link
Member Author

jlemesh commented Oct 9, 2024

3.13 tests fail with:

reana_client/api/client.py:10: in <module>
    import cgi
E   ModuleNotFoundError: No module named 'cgi'

CGI module is "Deprecated since version 3.11, will be removed in version 3.13": https://docs.python.org/3/library/cgi.html

@tiborsimko
Copy link
Member

3.13 tests fail with:

We use cgi in one place only:

$ git grep cgi
reana_client/api/client.py:10: import cgi
reana_client/api/client.py:504:            value, params = cgi.parse_header(content_disposition)

Can you look at updating that part of the code?

jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 10, 2024
@jlemesh jlemesh force-pushed the feature_add_support_for_python313 branch from b885896 to 3d4467b Compare October 10, 2024 09:13
@jlemesh jlemesh force-pushed the feature_add_support_for_python313 branch from 3d4467b to 80d88dc Compare October 10, 2024 09:16
@jlemesh jlemesh changed the title ci(actions): add support for python 3.13 (#732) build(python): add support for Python 3.13 (#732) Oct 10, 2024
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests 👍

@tiborsimko tiborsimko merged commit 80d88dc into reanahub:master Oct 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: start testing Python 3.13
2 participants