cli: implement filtering by status and search by name

[ParthS007]

closes #427

[mvidalgarcia]

I think there was a misunderstanding with the issue description and I'm sorry about that. The idea behind the issue was making use of the recently added args in reana-server. In other words, passing these args (search and status) directly in this call so the server does the heavy lifting. @tiborsimko Did you understand the same? Probably the issue wasn't well enough explained...

[tiborsimko]

Yes, I understand it the same, but there were two things, actually: (1) adding new filters and (2) amending old format/filter convention to standardise across various r-client commands... So both parts need to be addressed...

[mvidalgarcia]

I get this:

$ reana-client list
Workflow list could not be retrieved: 
local variable 'status_filter' referenced before assignment

Do you get the same?

PS. It seems you need to rebase on top of the latest master.

[ParthS007]

@mvidalgarcia Can you please try now, I rebased it.

[mvidalgarcia]

A)
Can you reproduce this?

$ reana-client list
NAME           RUN_NUMBER   CREATED               STARTED               ENDED                 STATUS  
roofit-fail    1            2020-10-14T10:42:20   2020-10-14T10:42:21   2020-10-14T10:42:38   failed  
roo            1            2020-10-14T10:23:06   2020-10-14T10:23:06   2020-10-14T10:23:30   finished
root6-roofit   1            2020-10-14T10:22:48   2020-10-14T10:22:49   2020-10-14T10:23:13   finished
$ reana-client list --format status=failed,name=test_workflow  
Workflow list could not be retrieved: 
list.remove(x): x not in list
$ reana-client list --format status=failed,name=roofit-fail  
Workflow list could not be retrieved: 
list.remove(x): x not in list

I might only happen when there are failed workflows (?)

B)
I see that we have --format for listing workflow files, could we amend the variable name to be consistent, i.e. name it _format?

[mvidalgarcia]

A couple of more comments, it's looking great 🚀

[ParthS007]

A)
Can you reproduce this?

$ reana-client list
NAME           RUN_NUMBER   CREATED               STARTED               ENDED                 STATUS  
roofit-fail    1            2020-10-14T10:42:20   2020-10-14T10:42:21   2020-10-14T10:42:38   failed  
roo            1            2020-10-14T10:23:06   2020-10-14T10:23:06   2020-10-14T10:23:30   finished
root6-roofit   1            2020-10-14T10:22:48   2020-10-14T10:22:49   2020-10-14T10:23:13   finished
$ reana-client list --format status=failed,name=test_workflow  
Workflow list could not be retrieved: 
list.remove(x): x not in list
$ reana-client list --format status=failed,name=roofit-fail  
Workflow list could not be retrieved: 
list.remove(x): x not in list

I might only happen when there are failed workflows (?)

B)
I see that we have --format for listing workflow files, could we amend the variable name to be consistent, i.e. name it _format?

@mvidalgarcia

A ) Yes, It is happening for me as well, I can work on it to fix this in a different issue.

B ) Done 👍

[mvidalgarcia]

🎸!