Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors for skipped blocks on mli #462

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

samoht
Copy link
Collaborator

@samoht samoht commented Dec 6, 2024

Opening this to discuss how to fix this best -- this seems to be almost working with that ugly function

@samoht samoht force-pushed the fix-errors-mli branch 2 times, most recently from 03bed22 to 51b1adf Compare December 6, 2024 20:13
@samoht samoht changed the title WIP: fix errors for skipped blocks on mli Fix errors for skipped blocks on mli Dec 6, 2024
@samoht samoht force-pushed the fix-errors-mli branch 4 times, most recently from ff1ca76 to 81210a9 Compare December 6, 2024 21:06
@samoht samoht merged commit 4cda2e1 into realworldocaml:main Dec 6, 2024
1 of 3 checks passed
@samoht samoht deleted the fix-errors-mli branch December 6, 2024 21:10
samoht added a commit to samoht/opam-repository that referenced this pull request Dec 7, 2024
CHANGES:

#### Added

- Support OCaml 5.3 (realworldocaml/mdx#457, @anmonteiro, @samoht, @voodoos)
- Support multiple version labels in block headers. The block is active if all
  the version formulaes are satisfied (realworldocaml/mdx#458, @samoht)

#### Fixed

- Avoid infinite loop in lexer on unclosed code block (realworldocaml/mdx#444, @edwintorok)
- Fix support for skipped blocks in mli and mld files (realworldocaml/mdx#462, @samoht)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant