Add an 'exec' label to execute include OCaml blocks #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will have a look, but we need some logic to add this to the dependencies as pointed here! |
panglesd
reviewed
Mar 26, 2024
| | `OCaml -> | ||
| let kind = | ||
| Util.Option.value ~default:OCaml_kind.Impl | ||
| (OCaml_kind.infer_from_file file_included) |
There was a problem hiding this comment.
Nitpick: Ocaml_kind.infer_from_file is called twice in a few lines... Maybe store the result in the `OCaml polymorphic variant?
(This would also remove the call to Option.value)
Comment on lines
+32
to
+33
| Line 1, characters 1-7: | ||
| Error: Unbound module Pipe |
There was a problem hiding this comment.
Do you have an idea why this PR is making this change? It seems wrong!
|
@panglesd I completely forgot what this is about, is this still needed? I'm fine with closing it and reopening something cleaner when needed. |
|
I don't need this anymore, so it can be closed. I think there are more urgent tasks to make it usable in mli/mld files! (eg, resilience to formatting issues!) |
|
Not needed anymore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #446
The code of panglesd@85b9142 is already squashed, so that's a more difficult to go back in time. I couldn't re-create that behavior yet.
@panglesd if you see something weird with the exec/skip interaction for the ocaml includes I'm interested :)