Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDART-1069: Allow subscription set to be mocked #1741

Merged
merged 3 commits into from
Jul 10, 2024
Merged

RDART-1069: Allow subscription set to be mocked #1741

merged 3 commits into from
Jul 10, 2024

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Jul 5, 2024 •
edited by nirinchev
Loading

Fixes #1744

@cla-bot cla-bot bot added the cla: yes label Jul 5, 2024
@nielsenko nielsenko changed the base branch from main to kn/update-core July 5, 2024 13:38
@nielsenko nielsenko force-pushed the kn/allow-subscription-set-to-be-mocked branch from decd727 to c6950ea Compare July 5, 2024 14:09
Base automatically changed from kn/update-core to main July 5, 2024 14:46
@nielsenko nielsenko force-pushed the kn/allow-subscription-set-to-be-mocked branch from c6950ea to ff69810 Compare July 5, 2024 14:55
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9810162826

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.91%
Totals Coverage Status
Change from base Build 9810057951: 0.0%
Covered Lines: 5982
Relevant Lines: 6883
💛 - Coveralls

@nirinchev nirinchev marked this pull request as ready for review July 10, 2024 21:11
@nirinchev nirinchev changed the title Allow subscription set to be mocked RDART-1069: Allow subscription set to be mocked Jul 10, 2024
@nirinchev nirinchev merged commit 2f463e0 into main Jul 10, 2024
24 of 26 checks passed
@nirinchev nirinchev deleted the kn/allow-subscription-set-to-be-mocked branch July 10, 2024 21:13
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 9881547338

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.91%
Totals Coverage Status
Change from base Build 9810057951: 0.0%
Covered Lines: 5982
Relevant Lines: 6883
💛 - Coveralls

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow subscriptionset to be mocked
2 participants
@nielsenko @nirinchev