Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-1014: Bump required sdk version to ^3.3.0 #1648

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

@nielsenko nielsenko self-assigned this Apr 24, 2024
@cla-bot cla-bot bot added the cla: yes label Apr 24, 2024
@nielsenko nielsenko changed the title Bump required sdk version to ^3.3.0 RDART-1014: Bump required sdk version to ^3.3.0 Apr 24, 2024
Copy link

coveralls-official bot commented Apr 24, 2024

Pull Request Test Coverage Report for Build 8818539538

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 86.74%

Totals Coverage Status
Change from base Build 8818523632: 0.3%
Covered Lines: 5894
Relevant Lines: 6795

💛 - Coveralls

This is to avoid a few Dart compiler bugs related to Finalizable objects:
- dart-lang/sdk#54414
- dart-lang/sdk#52596
- dart-lang/sdk#51538
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though some tests are failing - might be worth re-running or looking into what went wrong.

@nielsenko nielsenko merged commit 82a0b78 into main Apr 24, 2024
54 of 56 checks passed
@nielsenko nielsenko deleted the kn/compiler-bug branch April 24, 2024 15:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0 To 2.1.0, realm_core.dart Function _createConfig changed
2 participants