Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDART-852: Allow private fields on models #1635

Merged
merged 2 commits into from
Apr 17, 2024
Merged

RDART-852: Allow private fields on models #1635

merged 2 commits into from
Apr 17, 2024

Conversation

nielsenko
Copy link
Contributor

Fixes: #1367

@cla-bot cla-bot bot added the cla: yes label Apr 17, 2024
@nielsenko nielsenko changed the title Allow private fields on models RDART-852: Allow private fields on models Apr 17, 2024
@nielsenko nielsenko force-pushed the kn/allow-private-props-on-realm-model branch from af883b0 to 5ef3813 Compare April 17, 2024 06:21
@nielsenko nielsenko requested a review from papafe April 17, 2024 06:22
@nielsenko nielsenko marked this pull request as ready for review April 17, 2024 06:22
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8717267576

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.346%
Totals Coverage Status
Change from base Build 8659161761: 0.0%
Covered Lines: 5856
Relevant Lines: 6782
💛 - Coveralls

papafe
papafe approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nielsenko nielsenko merged commit 642f2a6 into main Apr 17, 2024
57 of 58 checks passed
@nielsenko nielsenko deleted the kn/allow-private-props-on-realm-model branch April 17, 2024 06:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private properties are ignored on Realm model generation
2 participants
@nielsenko @papafe