Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-1006: Reference equality implies equality #1633

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

nielsenko
Copy link
Contributor

Fixes: #1632

@cla-bot cla-bot bot added the cla: yes label Apr 16, 2024
@nielsenko nielsenko changed the title Reference equality implies equality #RDART-1006: Reference equality implies equality Apr 16, 2024
@nielsenko nielsenko changed the title #RDART-1006: Reference equality implies equality RDART-1006: Reference equality implies equality Apr 16, 2024
@nielsenko nielsenko requested a review from papafe April 16, 2024 12:48
@nielsenko
Copy link
Contributor Author

nielsenko commented Apr 16, 2024

One thing to be aware of still is that:

final x = [RealmValue.from(1)];
final xrv = RealmValue.from(x);
expect(xrv, xrv); // ref eq
expect(xrv, RealmValue.from(x)); // value ref eq

final y = [1];
final yrv = RealmValue.from(y);
expect(yrv, yrv); // ref eq
expect(yrv, isNot(RealmValue(y))); // value not ref eq, as internal list is mapped to RealmValue's

@nielsenko nielsenko marked this pull request as ready for review April 16, 2024 12:53
Copy link

coveralls-official bot commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8718741421

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.346%

Totals Coverage Status
Change from base Build 8718715498: 0.0%
Covered Lines: 5856
Relevant Lines: 6782

💛 - Coveralls

@nielsenko nielsenko requested a review from rorbech April 16, 2024 13:09
@nielsenko nielsenko changed the base branch from main to kn/optimize-realmvalue-eq April 16, 2024 13:33
Base automatically changed from kn/optimize-realmvalue-eq to main April 17, 2024 08:26
@nielsenko nielsenko merged commit 5cfd94a into main Apr 17, 2024
46 of 47 checks passed
@nielsenko nielsenko deleted the kn/fix-realm-value-eq branch April 17, 2024 08:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RealmValue.operator== bug
3 participants