Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDART-963: Update to new base url #1620

Merged
merged 2 commits into from
Apr 8, 2024
Merged

RDART-963: Update to new base url #1620

merged 2 commits into from
Apr 8, 2024

Conversation

nirinchev
Copy link
Member

Fixes #1549

@cla-bot cla-bot bot added the cla: yes label Apr 7, 2024
elle-j
elle-j approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating two URLs 👍

packages/realm_dart/test/app_test.dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like two more tests needs the URL updated 👍

nielsenko
nielsenko approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .. but the tests @elle-j mentioned needs an update

@nirinchev nirinchev merged commit 67d17a4 into ni/schema-migration Apr 8, 2024
56 checks passed
@nirinchev nirinchev deleted the ni/new-base-url branch April 8, 2024 14:09
nirinchev added a commit that referenced this pull request Apr 8, 2024
@nirinchev @nielsenko
RDART-987: Schema migration support (#1586)
1718e6a 
* wip

* Rework tests to use static schema

* Fix some tests

* extend test a bit

* Add more tests

* Add changelog entry

* address some feedback

* Fix year

* RDART-963: Update to new base url (#1620)

* Update to new base url

* Fix tests

* Apply suggestions from code review

Co-authored-by: Kasper Overgård Nielsen <[email protected]>

* Update enum name

---------

Co-authored-by: Kasper Overgård Nielsen <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@elle-j elle-j elle-j approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirinchev @nielsenko @elle-j