RDART-996: Don't serialize backlinks #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
force-pushed
the
kn/no-backlink-serialization
branch
from
ae45fb0
to
1ef67f5
Compare
nielsenko
changed the title
Pull Request Test Coverage Report for Build 8554468940Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/no-backlink-serialization
branch
from
5f68c48
to
1662e44
Compare
elle-j
approved these changes
Apr 4, 2024
packages/realm_generator/test/good_test_data/all_types.expected
Outdated
Show resolved
Hide resolved
nielsenko
force-pushed
the
kn/no-backlink-serialization
branch
from
1662e44
to
cc8e03f
Compare
papafe
added a commit
that referenced
this pull request
Apr 8, 2024
* main: RDART-996: Don't serialize backlinks (#1617) Update README.md (#1608) RDART-983: Refactor how we open dynamic library to give better error message (#1614) RDART-991: Rename Key enum (#1613) RDART-992: Handle Identifer expression as well (#1612) Add workflow_dispatch for development Common setup script (#1610) RDART-992: Const initializer evaluation is too simple (#1607) # Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backlinks are computed values and cannot be deserialized, and shouldn't be serialized either. Especially since we don't handle cycles during serialization gracefully, and backlinks are guarenteed cycles.
Fix #1616