Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-992: Handle Identifer expression as well #1612

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

nielsenko
Copy link
Contributor

As mentioned in #1606 (comment) identifier expressions are not considered when establishing const-ness. This PR fixes that.

@cla-bot cla-bot bot added the cla: yes label Apr 2, 2024
@nielsenko nielsenko changed the title Handle Identifer expression as well RDART-992: Handle Identifer expression as well Apr 2, 2024
@nielsenko nielsenko added the no-changelog Used to skip the changelog check label Apr 2, 2024
@nielsenko
Copy link
Contributor Author

Added no-changelog label, as this is a fix to a fix that is not yet released.

Copy link

Pull Request Test Coverage Report for Build 8519302137

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 86.229%

Totals Coverage Status
Change from base Build 8480864410: 0.002%
Covered Lines: 5836
Relevant Lines: 6768

💛 - Coveralls

Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nielsenko nielsenko merged commit 0d8e6d5 into main Apr 2, 2024
56 checks passed
@nielsenko nielsenko deleted the kn/fix-const-init-bug-take-2 branch April 2, 2024 08:17
papafe added a commit that referenced this pull request Apr 8, 2024
* main:
  RDART-996: Don't serialize backlinks (#1617)
  Update README.md (#1608)
  RDART-983: Refactor how we open dynamic library to give better error message (#1614)
  RDART-991: Rename Key enum (#1613)
  RDART-992: Handle Identifer expression as well (#1612)
  Add workflow_dispatch for development
  Common setup script (#1610)
  RDART-992: Const initializer evaluation is too simple (#1607)

# Conflicts:
#	CHANGELOG.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants