Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kn/mwb/update baseurl #1496

Merged
merged 8 commits into from
Jan 29, 2024
Merged

kn/mwb/update baseurl #1496

merged 8 commits into from
Jan 29, 2024

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Jan 29, 2024 •
edited
Loading

  • Added App.update_base_url()
  • Added tests
  • Updated changelog
  • Updated realm bindings
  • Fixed core mapping
  • Updated test for App.updateBaseUrl()
  • Make getBaseUrl() a property (baseUrl)

Mostly a rebase of #1454

@cla-bot cla-bot bot added the cla: yes label Jan 29, 2024
michael-wb
michael-wb approved these changes Jan 29, 2024
View reviewed changes
Copy link

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - you caught the @experimental designation before I had a chance to comment 🙂

@nielsenko nielsenko marked this pull request as ready for review January 29, 2024 14:10
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7697254626

  • 0 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 87.404%
Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.91%
Totals Coverage Status
Change from base Build 7667881425: 0.05%
Covered Lines: 3740
Relevant Lines: 4279
💛 - Coveralls

@nielsenko nielsenko merged commit 3fd4d49 into main Jan 29, 2024
56 checks passed
@nielsenko nielsenko deleted the kn/mwb/update-baseurl branch January 29, 2024 14:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael-wb michael-wb michael-wb approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsenko @michael-wb