Add support for RealmObject.getBacklinks #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
approved these changes
Jan 23, 2024
test/backlinks_test.dart
Outdated
| isA<RealmResultsChanges<Source>>().having((ch) => ch.inserted, 'inserted', [0]), | ||
| isA<RealmResultsChanges<Source>>().having((ch) => ch.inserted, 'inserted', [1]), | ||
| isA<RealmResultsChanges<Source>>() // | ||
| .having((ch) => ch.inserted, 'inserted', [0, 2]) // is this surprising? |
There was a problem hiding this comment.
That backlinks does not have a "natural" order, you mean?
There was a problem hiding this comment.
Oh, I copied the test, so didn't take a look at the comment. I can remove it.
There was a problem hiding this comment.
.. My own comment I see 😊
Pull Request Test Coverage Report for Build 7626920105
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the title - it allows users to find backlinks regardless of whether they've defined a computed property in their models explicitly. The only thing I'm uncertain about is whether we want to put it on the RealmObject as it's polluting the interface a little for what is arguably niche functionality.
Fixes #1480