Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MigrationRequiredException #1459

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add MigrationRequiredException #1459

merged 2 commits into from
Jan 8, 2024

Conversation

nirinchev
Copy link
Member

Fixes #1448

Copy link

Pull Request Test Coverage Report for Build 7423689685

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 87.145%

Totals Coverage Status
Change from base Build 7400751707: -0.02%
Covered Lines: 3654
Relevant Lines: 4193

💛 - Coveralls

Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One thing. Previously we mostly just threw RealmException on errors. We might benefit from using a similar pattern of creating a separate exception type in other situations as well.

@nirinchev
Copy link
Member Author

Yes, creating dedicated exceptions is worthwhile, but I'd probably do it on demand rather than all at once.

@nirinchev nirinchev merged commit ecdce26 into main Jan 8, 2024
48 of 49 checks passed
@nirinchev nirinchev deleted the ni/migration-exception branch January 8, 2024 13:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating Migrations in a local first RealmDb Configuration
2 participants