Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update realm-core to v13.25.1 #1458

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Update realm-core to v13.25.1 #1458

merged 3 commits into from
Jan 17, 2024

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Jan 3, 2024

Fixes: #1473

Copy link

coveralls-official bot commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7554588945

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 87.145%

Totals Coverage Status
Change from base Build 7538958708: 0.02%
Covered Lines: 3654
Relevant Lines: 4193

💛 - Coveralls

@nielsenko nielsenko force-pushed the kn/update-core branch 2 times, most recently from 3e99cf2 to 0cec80f Compare January 4, 2024 13:17
@nielsenko nielsenko marked this pull request as ready for review January 16, 2024 08:32
CHANGELOG.md Outdated
(PR [#7161](https://github.com/realm/realm-core/pull/7161), Core 13.24.1).
* If the very first open of a flexible sync Realm triggered a client reset, the configuration had an initial subscriptions callback, both before and after reset callbacks, and the initial subscription callback began a read transaction without ending it (which is normally going to be the case), opening the frozen Realm for the after reset callback would trigger a BadVersion exception (PR [#7161](https://github.com/realm/realm-core/pull/7161), Core 13.24.1).
* Changesets have wrong timestamps if the local clock lags behind 2015-01-01T00:00:00Z. The sync client now throws an exception if that happens. (PR [#7180](https://github.com/realm/realm-core/pull/7180), Core 13.24.1)
* Allow propagation of user code exceptions happening during client reset callbacks. (Issue [#7098](https://github.com/realm/realm-core/issues/7098), Core 13.24.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here I believe - it's internal and the dart side of it is captured in

* Errors in user-provided client reset callbacks, such as `RecoverOrDiscardUnsyncedChangesHandler.onBeforeReset/onAfterDiscard` would not be correctly propagated and the client reset exception would contain a message like `A fatal error occurred during client reset: 'User-provided callback failed'` but no details about the actual error. Now `SyncError` has an `innerError` field which contains the original error thrown in the callback. (PR [#1447](https://github.com/realm/realm-dart/pull/1447))
.

@nielsenko nielsenko merged commit ac909cf into main Jan 17, 2024
25 checks passed
@nielsenko nielsenko deleted the kn/update-core branch January 17, 2024 10:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade realm-core to 13.25.1
2 participants