Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework app isolate API #1445

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Rework app isolate API #1445

merged 4 commits into from
Dec 8, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Dec 4, 2023

Fixes #1433

Copy link

coveralls-official bot commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7135071089

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 88.406%

Totals Coverage Status
Change from base Build 7083397893: 0.06%
Covered Lines: 3477
Relevant Lines: 3933

💛 - Coveralls

Copy link
Member

@tgoyne tgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously I can't judge if the dart code is good but this all looks reasonable to me.

@nirinchev
Copy link
Member Author

Thanks @tgoyne, appreciate the review! I mostly needed a high-level sanity check to make sure this approach is sound and in line with how the Core API are supposed to be used.

@nirinchev nirinchev merged commit a510010 into main Dec 8, 2023
45 of 48 checks passed
@nirinchev nirinchev deleted the ni/app-isolates branch December 8, 2023 01:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to open realm on background isolate
2 participants