Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default context rather than creating a new one #1426

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

nirinchev
Copy link
Member

This appears to have caused issues on Android where we would get certificate validation errors.

@nirinchev nirinchev merged commit 6cb6822 into main Nov 14, 2023
11 of 12 checks passed
@nirinchev nirinchev deleted the ni/default-context branch November 14, 2023 15:46
nirinchev added a commit that referenced this pull request Nov 14, 2023
* main:
  Use default context rather than creating a new one (#1426)
Copy link

Pull Request Test Coverage Report for Build 6866029546

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 88.469%

Files with Coverage Reduction New Missed Lines %
lib/src/realm_class.dart 1 94.48%
Totals Coverage Status
Change from base Build 6822741530: -0.03%
Covered Lines: 3422
Relevant Lines: 3868

💛 - Coveralls

nirinchev added a commit that referenced this pull request Nov 30, 2023
* main:
  Don't add the ISRG X1 Root on Android (#1434)
  Wait for initial sync to complete before starting the tests (#1435)
  kn/update analyzer (#1365)
  Add vNext Changelog header (#1429)
  [Release 1.6.0] (#1428)
  Upgrade to Core 13.23.4 (#1427)
  Flexible sync subscribe/unsubscribe API (#1354)
  Use default context rather than creating a new one (#1426)
  Handle duplicate certificates (#1425)
  kn/add certificate (#1378)
  asymmetric object allow non embedded links (#1402)
  Rudimentary geospatial support (#1389)
  Core 13.20.1 sync errors changes (#1387)
  Fix RealmObject.hashCode (#1420)
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant