Support maps #1406
Merged
Support maps #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very early draft |
|
Hello, do you still have plans to support maps in realm-dart? |
|
@tanguy-penfen I assume so, but it is unlikely to be me doing it. The dedicated Dart team I was part of has been dissolved, and instead maintenance of the SDK has moved under the .NET team. Tagging @nirinchev as he may know more? This is just a very early placeholder PR I created. 95% of the work is still outstanding. |
|
This is related to #685. I see @nirinchev has already commented there. |
nirinchev
force-pushed
the
kn/realm-maps
branch
from
ccd5ecb
to
3545760
Compare
nielsenko
commented
Jan 3, 2024
Pull Request Test Coverage Report for Build 7399631971
💛 - Coveralls |
|
Great news. From what version will this feature be available? |
Next version |
|
We want to include a few more bugfixes but hope to release it in the next few weeks. |
nirinchev
added a commit
that referenced
this pull request
Jan 3, 2024
* Update generator to support maps * Generator updates * Better error message for wrong key type * Remove the default value lists * Add tests for non-empty default collection initializers * Wire up some of the implementation * Wire up most of the test infrastructure * Add notification tests * Fix generator test expects * Fix tests * Add changelog, clean up the generator a little * Revert some unneeded changes * Fix expectations --------- Co-authored-by: Nikola Irinchev <[email protected]>
nirinchev
added a commit
that referenced
this pull request
Jan 3, 2024
* Use baasaas on CI * Remove dependency on realm in the baas client * Regenerate models * Cleanup containers after test runs * Fix CI * Try setting the baas url correctly * Fix order of test setup * .. * Add some missing flutter tests * Try to fix flutter tests * Rework indexed test to use values from the second half of the table. * Use api key auth * Post-merge fixes * Use endpoints, wire-up differentiator tag * Guard against incomplete containers * Fix cleanup workflow; fix env variable names * Don't log isolate warnings when the isolate is created by dart test * Pass correct differentiator to android tests * Always run cleanup * Rework cleanup command * Use reporter * Don't fail test run on test errors * Fail on error * Remove failing test * Update lib/src/cli/atlas_apps/options.dart Co-authored-by: Kasper Overgård Nielsen <[email protected]> * Support maps (#1406) * Update generator to support maps * Generator updates * Better error message for wrong key type * Remove the default value lists * Add tests for non-empty default collection initializers * Wire up some of the implementation * Wire up most of the test infrastructure * Add notification tests * Fix generator test expects * Fix tests * Add changelog, clean up the generator a little * Revert some unneeded changes * Fix expectations --------- Co-authored-by: Nikola Irinchev <[email protected]> * Merge main, regenerate cli --------- Co-authored-by: Kasper Overgård Nielsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #685.
Fixes #778.
TODO: