Avoid blocking in Transaction::close() when there's a cancelled async write when possible #6413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't cancel the wait for the write lock if another process currently holds it, but if the DB for the current Transaction holds it and we're just waiting in the write queue then we can safely close the Transaction immediately and simply skip over it when it would get its turn to write.
This used to require writing some pretty convoluted code to run into, but with structured concurrency it's much easier to accidentally write something that'll deadlock. For example, the following code does: