Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract method for common code and make signatures swiftier #5554

Merged
merged 1 commit into from
May 1, 2024

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

2 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
17 Messages
📖 Linting Aerial with this PR took 0.18s vs 0.17s on main (5% slower)
📖 Linting Alamofire with this PR took 0.16s vs 0.16s on main (0% slower)
📖 Linting Brave with this PR took 0.66s vs 0.66s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 0.51s vs 0.51s on main (0% slower)
📖 Linting Firefox with this PR took 1.3s vs 1.3s on main (0% slower)
📖 Linting Kickstarter with this PR took 0.72s vs 0.73s on main (1% faster)
📖 Linting Moya with this PR took 0.11s vs 0.11s on main (0% slower)
📖 Linting NetNewsWire with this PR took 0.27s vs 0.27s on main (0% slower)
📖 Linting Nimble with this PR took 0.13s vs 0.14s on main (7% faster)
📖 Linting PocketCasts with this PR took 0.66s vs 0.66s on main (0% slower)
📖 Linting Quick with this PR took 0.1s vs 0.1s on main (0% slower)
📖 Linting Realm with this PR took 0.51s vs 0.51s on main (0% slower)
📖 Linting Sourcery with this PR took 0.32s vs 0.32s on main (0% slower)
📖 Linting Swift with this PR took 0.42s vs 0.42s on main (0% slower)
📖 Linting VLC with this PR took 0.18s vs 0.18s on main (0% slower)
📖 Linting Wire with this PR took 1.71s vs 1.71s on main (0% slower)
📖 Linting WordPress with this PR took 1.02s vs 1.02s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Extract method for common code and make signatures swiftier.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@SimplyDanny SimplyDanny enabled auto-merge (squash) May 1, 2024 19:48
@SimplyDanny SimplyDanny merged commit 1658f1d into realm:main May 1, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the extract-method branch May 1, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants