Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong rotation of the predicted actions #65

Open
yl-wang996 opened this issue Apr 25, 2024 · 9 comments
Open

wrong rotation of the predicted actions #65

yl-wang996 opened this issue Apr 25, 2024 · 9 comments

Comments

@yl-wang996
Copy link

As in the following figure, I try to visualize the predicted actions in the rviz. In this case, each prediction will generate 16 waypotins and the first 8 will be used. But I found the rotation part of the action is incorrect, there seems exist a fixed offset in the rotation. And the action is directly from here.

So my question is: is this rotation correct as in the following image, if not what could be the problem?

image

@yl-wang996 yl-wang996 changed the title wrong orientation of the predicted action wrong rotation of the predicted actions Apr 25, 2024
@yl-wang996
Copy link
Author

When I visualize the trajectories of the TCP, the rotation seems correct.
image

@yl-wang996
Copy link
Author

And then I found the action in the demonstration dataset is also not vertical, is it correct?
image

@2292685327
Copy link

Hello, I am a beginner, how to use rviz for visualization?

@yl-wang996
Copy link
Author

Hello, I am a beginner, how to use rviz for visualization?

@2292685327 Basically, you just need to know how to use ROS, and for rviz you can refer to here

@2292685327
Copy link

Hello, I am a beginner, how to use rviz for visualization?

@2292685327 Basically, you just need to know how to use ROS, and for rviz you can refer to here

Thank you for your prompt reply. I have another question. Are the robot files and required target files in the simulation environment already provided in the source code? Or do I need to recreate it myself?

@yl-wang996
Copy link
Author

@2292685327 sorry for the late reply, the robomimic rely on the robosuite, so the env is built by robosuite. An alternative is you can find the mujoco XML file in the attributes of the dataset file(***.h5py), but the path is wrong in this XML file.

@cynthia-you
Copy link

As in the following figure, I try to visualize the predicted actions in the rviz. In this case, each prediction will generate 16 waypotins and the first 8 will be used. But I found the rotation part of the action is incorrect, there seems exist a fixed offset in the rotation. And the action is directly from here.

So my question is: is this rotation correct as in the following image, if not what could be the problem?

image

——————————————————————————————————————————————
Hi, did you solved this problem, for my dataset i get the seem results: little error in pose position, but large eorro in rotation. i found they use rotation_6d in model,not 3x3_rot_matrix. I have tried the 'abs'/'rel'/'relative' as the action_reper, but all got the run rotation position.

@yl-wang996
Copy link
Author

yl-wang996 commented Aug 27, 2024

@cynthia-you I haven't tried, but I guess using the axis value with angle magnitude, which also means axis angle, could resolve this problem. I accidentally used Euler angle for drawing the rviz, which cause a mistake.

@wudier483
Copy link

@2292685327 sorry for the late reply, the robomimic rely on the robosuite, so the env is built by robosuite. An alternative is you can find the mujoco XML file in the attributes of the dataset file(***.h5py), but the path is wrong in this XML file.

@yl-wang996 Thank you for your response. Is your visualization result based on the depth information from a global camera? Also, when visualizing through RViz, what specific information from the source code is needed for the camera and trajectory data, respectively? I look forward to your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants