Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use relative URLs when deploying #263

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Don't use relative URLs when deploying #263

merged 1 commit into from
Feb 19, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Feb 15, 2024

@stsewd stsewd requested a review from agjohnson February 15, 2024 21:40
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say if this is going to have any unwanted side effects, but I like your solution much better. If it isn't already, we should document this configuration, as I'm sure it's common.

@stsewd
Copy link
Member Author

stsewd commented Feb 15, 2024

If it isn't already, we should document this configuration, as I'm sure it's common.

Do you mean in this repo? Or on RTD docs?

@agjohnson
Copy link
Contributor

Oh sorry, yeah in our user docs. Unfortunately, we only expose this in our docs in the build commands page, so this configuration is a bit out of scope for that page:

https://docs.readthedocs.io/en/stable/build-customization.html#pelican

I think we were trying to use another repository to show some examples though, maybe there instead?

@humitos where were we documenting examples for build tools?

@humitos
Copy link
Member

humitos commented Feb 19, 2024

@humitos where were we documenting examples for build tools?

Not sure, but you may refer to https://github.com/readthedocs-examples/ organization. It currently has Sphinx, MkDocs and Jupyter Book examples. A contributor added Antora at (https://github.com/man-chi/example-antora-basic/) that we should migrate into our organization somehow to gain control.

That organization is a good place to create a Pelican example if we want to document this somewhere.

@stsewd stsewd merged commit ce66288 into main Feb 19, 2024
5 checks passed
@stsewd stsewd deleted the use-absolute-urls branch February 19, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not found page only works on / (root pages)
3 participants