Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: reduce visibility of Config File V1 #8887

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 3, 2022

People is still arriving at Config File V1 and we want to avoid that as much as
possible. However, we can't yet remove this documentation page since it's still
working and there are people already using it.

We should find a way to migrate these projects off from Config File V1 and
finally remove this documentation page. However, that requires a much bigger
amount of work.

Closes #8857

@humitos humitos requested a review from a team as a code owner February 3, 2022 14:52
@agjohnson
Copy link
Contributor

Discussed in the underlying #8648, we can get more aggressive with this change and I think it would help doc clarity. The main points on that issue are 1) don't refer to our config file as v2 and 2) remove the nesting of the configuration file index, just get straight to our configuration file details.

@humitos
Copy link
Member Author

humitos commented Feb 8, 2022

I'm moving this out to next's week deploy.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, agreed on improving the overall structure as the next step (or as part of this PR if you feel like it).

People is still arriving at Config File V1 and we want to avoid that as much as
possible. However, we can't yet remove this documentation page since it's still
working and there are people already using it.

We should find a way to migrate these projects off from Config File V1 and
finally remove this documentation page. However, that requires a much bigger
amount of work.
@humitos humitos enabled auto-merge February 14, 2022 19:30
@humitos humitos force-pushed the humitos/visibility-config-v1 branch from 07086a9 to 80bea10 Compare February 14, 2022 19:30
@humitos
Copy link
Member Author

humitos commented Feb 14, 2022

I will merge this small change as-is for now. We should come back to do a bigger refactor for our config docs. However, hiding this page will reduce the problem of people finding these docs and thinking they are up to date and they should use them.

@humitos humitos merged commit b5908b0 into master Feb 14, 2022
@humitos humitos deleted the humitos/visibility-config-v1 branch February 14, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants