-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: explains flyout position #11954
Conversation
- Small explanation of how to set the flyout position from the webui - Note for theme authors on how to explicitly define it from their themes Closes readthedocs/addons#498
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think we at least want to explain inline, or link to where it is defined?
docs/user/flyout-menu.rst
Outdated
<readthedocs-flyout position="bottom-left"></readthedocs-flyout> | ||
|
||
|
||
Available positions: ``bottom-left``, ``bottom-right``, ``top-left``, ``top-right``, ``inline``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't explain what inline
is in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed the mention to inline because I'm not 100% sure how it should behave yet -- so, I don't want to explain something that I'm not sure if it's correct.
We can come back here once we finish and merge readthedocs/addons#500
Co-authored-by: Eric Holscher <[email protected]>
Closes readthedocs/addons#498
📚 Documentation previews 📚
docs
): https://docs--11954.org.readthedocs.build/en/11954/dev
): https://dev--11954.org.readthedocs.build/en/11954/