Set session cookie SameSite attribute to Lax for main site
#11721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now injecting ads via addons, which doesn't make use of the sustainability endpoint. That endpoint was used to check if the user was a Gold member, and not show ads to them. The usage of the sustainability API was he only reason to set the `SameSite` attribute to `None`. Using Lax is more secure, as browser will never send the cookie in a cross-site request.
ericholscher
approved these changes
Oct 29, 2024
Do you mean like other place that depended on this? |
No, more like telling users that it's changed. But I think it's probably fine given it's a small number of users. |
|
That said, we can probably remove a bunch of the sustainability API code, since we aren't hitting it anymore, but not necessary in this PR. |
We can probably mention it in the newsletter. |
|
Good points were raised here. I think we need to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now injecting ads via addons,
which doesn't make use of the sustainability endpoint. That endpoint was used to check if the user was a Gold member, and not show ads to them.
The usage of the sustainability API was he only reason to set the
SameSiteattribute toNone.Using Lax is more secure, as browser will never send the cookie in a cross-site request.
📚 Documentation previews 📚
docs): https://docs--11721.org.readthedocs.build/en/11721/dev): https://dev--11721.org.readthedocs.build/en/11721/