Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: remove "addons enabled by default" notification #11651

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 7, 2024


📚 Documentation previews 📚

@humitos humitos changed the title Addons: remove "enabled by default" notification Build: remove "addons enabled by default" notification Nov 5, 2024
@humitos humitos marked this pull request as ready for review November 5, 2024 11:05
@humitos humitos requested a review from a team as a code owner November 5, 2024 11:05
@humitos humitos requested a review from stsewd November 5, 2024 11:05
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to also delete the notification itself?

@humitos
Copy link
Member Author

humitos commented Nov 5, 2024

It's not required. It's fine to keep showing that notification in old builds for now. We could delete it in the future if we consider, tho.

@humitos humitos merged commit 4f7b737 into main Nov 14, 2024
8 checks passed
@humitos humitos deleted the humitos/remove-addons-notification branch November 14, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants