Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally disabled custom 404 pages on dev docs #11596

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Sep 11, 2024

This is for testing error pages more in production and can be reverted later.


📚 Documentation previews 📚

This is for testing error pages more in production and can be reverted later.
@agjohnson agjohnson requested a review from a team as a code owner September 11, 2024 16:58
@agjohnson
Copy link
Contributor Author

I was going to test these in PR build, but readthedocs.build is pointing to our web scaling group. This PR only needs to be in place for a short while either way.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR builds would be another good one to point at the new serving -- low risk 👍

@agjohnson
Copy link
Contributor Author

Test failures seem unrelated, I'll merge this and we can continue pushing forward on testing with more domains later

@agjohnson agjohnson merged commit b30b665 into main Sep 11, 2024
5 of 6 checks passed
@agjohnson agjohnson deleted the agj/dev-docs-404 branch September 11, 2024 22:03
@humitos
Copy link
Member

humitos commented Sep 12, 2024

PR builds would be another good one to point at the new serving -- low risk 👍

I opened https://github.com/readthedocs/readthedocs-ops/issues/1533 and added to this sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants