-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions for Jupyter notebook galleries #11545
Conversation
BTW, Since you are mentioning "some examples of notebook galleries in the wild" and listing only a single one, I did a little search and found a few random galleries in the wild:
Feel free to add any of those to your list! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and updating it. We haven't updated with any list of examples in a while, so it might be good to add more current examples from your list too.
docs/user/guides/jupyter.rst
Outdated
This functionality is inspired by, but doesn't depend on | ||
`Sphinx-Gallery <https://sphinx-gallery.github.io/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we can just drop this mention of sphinx-gallery too, it's seems more confusing than helpful if we aren't going to explain the difference between the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've removed it in 2205a53.
I just realized that there was another mention of Sphinx-Gallery, which I removed in 9b3ce34. And I saw that the screenshot is outdated. The new default CSS style looks different and the default dummy thumbnail as well. |
I'm going to merge this PR, but feel free to open a another one with those more up-to-date gallery examples 💯 |
Thanks!
I'm not planning to do that. I was providing the example gallery links (#11545 (comment)) for someone else to take over! Same for the outdated screenshot. |
Since a while,
nbsphinx
doesn't depend on Sphinx-Gallery anymore and uses its own CSS (which can still be overwritten/extended by site authors), see spatialaudio/nbsphinx#706.📚 Documentation previews 📚
docs
): https://docs--11545.org.readthedocs.build/en/11545/dev
): https://dev--11545.org.readthedocs.build/en/11545/