Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n docs for Sphinx #11538

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

robredpath
Copy link
Contributor

@robredpath robredpath commented Aug 13, 2024


📚 Documentation previews 📚

@robredpath robredpath requested a review from a team as a code owner August 13, 2024 13:40
@ericholscher
Copy link
Member

Thanks for this! Looks like there is a linting check failing, and then we can merge it.

@humitos
Copy link
Member

humitos commented Aug 14, 2024

Just a note (no need to do this work on this PR).

I found that under "Projects with multiple translations (Sphinx-only)" section there is nothing Sphinx-specific actually. I think this is because our platform has growth and we can support translations for any type of doctool. If I'm understanding that section correctly, the same instructions work for any documentation tool now, right?

@ericholscher ericholscher merged commit 8f4d403 into readthedocs:main Aug 15, 2024
8 checks passed
humitos added a commit that referenced this pull request Aug 16, 2024
- Remove the "Sphinx-only" part since there wasn't almost anything related to
  Sphinx
- Use `godot` as example since it's a more maintained project with lot of
  translations
- Update the note to mention that guide is for Sphinx only projects.

Reference: #11538
humitos added a commit that referenced this pull request Aug 20, 2024
* Docs: make translation section more generic

- Remove the "Sphinx-only" part since there wasn't almost anything related to
  Sphinx
- Use `godot` as example since it's a more maintained project with lot of
  translations
- Update the note to mention that guide is for Sphinx only projects.

Reference: #11538

* Update docs/user/localization.rst

Co-authored-by: Anthony <[email protected]>

---------

Co-authored-by: Anthony <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants