Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention linting #11445

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Mention linting #11445

merged 3 commits into from
Jul 3, 2024

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Jul 1, 2024

Minimal viable pre-commit docs.


📚 Documentation previews 📚

@plaindocs plaindocs requested a review from humitos July 1, 2024 12:59
@plaindocs plaindocs requested a review from a team as a code owner July 1, 2024 12:59
@plaindocs plaindocs requested a review from ericholscher July 1, 2024 12:59
docs/dev/style-guide.rst Outdated Show resolved Hide resolved
docs/dev/style-guide.rst Show resolved Hide resolved
@plaindocs
Copy link
Contributor Author

plaindocs commented Jul 3, 2024

That CircleCI error looks unrelated to me, shall I merge?

Or do you have an idea of what to chase to fix?

@humitos
Copy link
Member

humitos commented Jul 3, 2024

Yes, don't worry about those tests --they are for the new dashboard and not related with your work. Thanks! I'm merging this PR now 👍🏼

@humitos humitos merged commit 8401ea6 into main Jul 3, 2024
7 of 8 checks passed
@humitos humitos deleted the sam/pre-commits branch July 3, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants