Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: Add deprecation and removal warning to Advanced Settings #10393

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Project: Add deprecation and removal warning to Advanced Settings #10393

merged 2 commits into from
Jun 9, 2023

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming requested a review from a team as a code owner June 6, 2023 15:40
@benjaoming benjaoming requested a review from agjohnson June 6, 2023 15:40
@benjaoming benjaoming added the Design Design or UX/UI related label Jun 6, 2023
@benjaoming benjaoming requested a review from humitos June 6, 2023 15:49
This was referenced Jun 8, 2023
Merged
Closed
humitos
humitos approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think we need to remove the link to the config file, tho. That way we point all the users to the same place avoiding confusions.

readthedocs/templates/projects/project_advanced_settings_helptext.html Outdated Show resolved Hide resolved
@benjaoming benjaoming merged commit 162d93e into readthedocs:main Jun 9, 2023
@benjaoming benjaoming deleted the deprecation-warning-project-advanced-settings branch June 9, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/frontend

Assignees

@benjaoming benjaoming

Labels
Design Design or UX/UI related
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaoming @humitos