Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: use APIv3 endpoint for resources #468

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
We are using the ?limit= paramenter in the endpoint now
humitos committed Jan 9, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit cd037dea29f4ff20104f0f8fd2dafb9cca95796e
5 changes: 0 additions & 5 deletions src/readthedocs-config.js
Original file line number Diff line number Diff line change
@@ -143,11 +143,6 @@ export async function getReadTheDocsConfigUsingAPIv3(sendUrlParam) {
const versionResponse = fetch(
addons.readthedocs.urls.api.v3.versions.current,
);
// TODO: the results come paginated, so we are only seeing the first 10 results.
// We need to perform more requests to get all the resulsts.
// What's the correct way to do that?
//
// The response comes with a `next` attribute that has the URL for the next 10 results.
const activeVersionsResponse = fetch(
addons.readthedocs.urls.api.v3.versions.active,
);