API: use APIv3 endpoint for resources #468
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation as a POC to give it a try. It works fine at first sight and I think it could be a good idea to move forward with it. I didn't find any blocker yet. Closes #356
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Dec 9, 2024
Comment on lines
+150
to
+152
| const filetreediffResponse = fetch( | ||
| addons.readthedocs.urls.api.v3.filetreediff, | ||
| ); |
There was a problem hiding this comment.
I worry a little bit about one of the API calls failing and leading to weird state. Would be good to put a TODO in here probably to do a retry?
There was a problem hiding this comment.
Yes. I need to re-write this code to handle errors as well. Currently, if an API call break, the whole code breaks completely 😅
There was a problem hiding this comment.
@agjohnson what's the best pattern to use for this chunk of code? async/await Promises (as it's written) or then-ables?
My goal here is to make multiple requests in parallel to APIv3 while handling errors. Besides, once that all requests have responded, I want to use the respond data to form the config object with the same structure we currently have.
humitos
commented
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation as a POC to give it a try. It works fine at first sight and I think it could be a good idea to move forward with it. I didn't find any blocker yet.
Closes #356
Requires readthedocs/readthedocs.org#11831