Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GH action path to always take current version #28

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change GH action path to always take current version #28

wants to merge 3 commits into from

Conversation

LecrisUT
Copy link

@LecrisUT LecrisUT commented Jun 8, 2023 •
edited by github-actions bot
Loading

@LecrisUT LecrisUT mentioned this pull request Jun 8, 2023
Open
@LecrisUT
Copy link
Author

LecrisUT commented Jun 8, 2023 •
edited
Loading

Hmm for some reason this doesn't work. I suspect it's because of:

on:
  pull_request_target:
    types:
      - opened

So that it still runs the version on main.

Edit: Indeed that was the case. Changing it on: pull_request fixes that.

@LecrisUT LecrisUT mentioned this pull request Jun 8, 2023
Open
@LecrisUT
Run on all PR triggers
da11578 
Ensures the PR version of the repo is used

Signed-off-by: Cristian Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LecrisUT