Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use project name rather than sdk in sdk snippet #898

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

darrenyong
Copy link
Contributor

@darrenyong darrenyong commented Jun 25, 2024

🚥 Resolves RM-6573

🧰 Changes

We wanted to update the sdk in our SDK snippet generation to use the site name so it feels more personalized.

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

@darrenyong darrenyong marked this pull request as draft June 25, 2024 23:10
@darrenyong darrenyong marked this pull request as ready for review June 26, 2024 20:02
packages/httpsnippet-client-api/src/index.ts Outdated Show resolved Hide resolved
@darrenyong darrenyong merged commit 6024ee0 into main Jun 27, 2024
5 checks passed
@darrenyong darrenyong deleted the darren/use-site-name-in-sdk-snippet branch June 27, 2024 02:18
@gkoberger
Copy link
Contributor

Yessss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants