Skip to content

docs: get started docs r-r version #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

docs: get started docs r-r version #1325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3548ff5
edit get started
adnjoo Dec 24, 2023
a075b75
gte v
adnjoo Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/get-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Also update the Babel configuration in the `package.json` file:

4. Install `react-rails`:
```bash
$ bundle add 'react-rails' --strict
$ bundle add 'react-rails' --strict --version '>=3.1.1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use "exact" version.

Copy link
Collaborator

@ahangarha ahangarha Dec 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I see one point. --strict doesn't count the patch version and when we have fixes and bump the patch value in the version, --strict doesn't help.

If there is any better proposal (than manually fix the version) please share.

CC: @Judahmeek @justin808

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the value of any changes. What am I missing?

$ rails generate react:install
```

Expand Down