-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[added] add Miscellaneous section to the contributions.md file #1023
Conversation
Thanks, @YassineOmrani. It would be better to also add the expected Unfortunately, this node release breaks compatibility with existing packages. |
On the stack trace, have you saw which package broke? |
loader-runner and some of webpack modules broke like createHash.js under utils and NormalModule.js |
Thanks for your quick reply @diasbruno i will make sure to that |
Thanks. I need to look those dependencies, as we can never trust node releases these days 😂. LEGIT. |
Hey @diasbruno, this doc change might be another good one to merge! 🙌 I ran across it when I was looking for the correct node version (with the goal of fixing some of the tests). :) |
This will cause problems on projects that uses node 18+. I'll open an issue to find which library has this dependency. |
Webpack 4 caching mechanism is one place where this issue happens. I'll try to upgrade webpack to see if it fixes for nodejs 18.
/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:133
if(isError) throw e;
^
Error: error:0308010C:digital envelope routines::unsupported
at new Hash (node:internal/crypto/hash:69:19)
at Object.createHash (node:crypto:133:10)
at module.exports (/Users/dias/Programming/react-modal/node_modules/webpack/lib/util/createHash.js:135:53)
at NormalModule._initBuildHash (/Users/dias/Programming/react-modal/node_modules/webpack/lib/NormalModule.js:417:16)
at handleParseError (/Users/dias/Programming/react-modal/node_modules/webpack/lib/NormalModule.js:471:10)
at /Users/dias/Programming/react-modal/node_modules/webpack/lib/NormalModule.js:503:5
at /Users/dias/Programming/react-modal/node_modules/webpack/lib/NormalModule.js:358:12
at /Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:373:3
at iterateNormalLoaders (/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
at iterateNormalLoaders (/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
at /Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:236:3
at context.callback (/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
at module.exports (/Users/dias/Programming/react-modal/node_modules/babel-loader/lib/index.js:182:8)
at LOADER_EXECUTION (/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:119:14)
at runSyncOrAsync (/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:120:4)
at iterateNormalLoaders (/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
at Array.<anonymous> (/Users/dias/Programming/react-modal/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
at Storage.finished (/Users/dias/Programming/react-modal/node_modules/webpack/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
at /Users/dias/Programming/react-modal/node_modules/webpack/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
at /Users/dias/Programming/react-modal/node_modules/graceful-fs/graceful-fs.js:123:16
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3) {
opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
library: 'digital envelope routines',
reason: 'unsupported',
code: 'ERR_OSSL_EVP_UNSUPPORTED'
} |
Fixes #1022 ].
Changes proposed:
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md
.