This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
[fixed] #309 - autoHighlight not working unless match is beginning of… #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning of an item
epegzz
commented
Jan 31, 2018
| @@ -65,7 +65,7 @@ describe('Autocomplete acceptance tests', () => { | |||
| it('should highlight top match when `props.value` changes', () => { | |||
| const tree = mount(AutocompleteComponentJSX({})) | |||
| expect(tree.state('highlightedIndex')).toEqual(null) | |||
| tree.setProps({ value: 'a' }) | |||
| tree.setProps({ value: 'ri' }) | |||
There was a problem hiding this comment.
The item we are matching here is Arizona.
In the old test we typed a, which put the Arizona item first and auto-highlighted it.
But if you typed ri then still Arizona was put as first item, but it was not auto-highlighted, since ri does not match the beginning of Arizona.
With the changes in this PR, Arizona will now correctly be highlighted.
epegzz
commented
Jan 31, 2018
| @@ -375,7 +375,7 @@ class Autocomplete extends React.Component { | |||
| const itemValue = getItemValue(matchedItem) | |||
| const itemValueDoesMatch = (itemValue.toLowerCase().indexOf( | |||
| value.toLowerCase() | |||
| ) === 0) | |||
| ) > -1) | |||
There was a problem hiding this comment.
I'd argue, that itemValueDoesMatch is even unnecessary.
If an item is displayed because it passed the check of shouldItemRender then we can also auto-highlight it if it's the first item in the list.
|
The existing logic won't be changed at the moment. See #239 for explanation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #309
The current implementation only auto-highlights an item if the input matches the beginning of the item label.
That's problematic if your
shouldItemRenderimplementation allows matching anywhere in the item label, not just from the start.This PR fixes that.