Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO tasks and change deprecated instruction #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ jobs:
java-version: 1.8
- name: Grant execute permission for gradlew
run: chmod +x gradlew
- name: Execute jacocoTestReport and Sonar
- name: Execute jacocoTestReport
run: ./gradlew test jacocoTestReport
- name: Run sonarqube
if: github.event.pull_request.head.repo.fork == false
env:
SONAR_TOKEN: ${{secrets.SONAR_TOKEN}}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: ./gradlew test jacocoTestReport sonarqube
# run: ./gradlew test jacocoTestReport && cp build/reports/jacoco/report.xml jacoco.xml || echo "Code coverage failed"
run: ./gradlew sonarqube
- name: Build with Gradle
run: ./gradlew build --refresh-dependencies --no-daemon --continue
# - name: Push codeCoverage to Codecov
# run: bash <(curl -s https://codecov.io/bash)

release:
if: github.event_name == 'release'
Expand All @@ -46,12 +46,8 @@ jobs:
java-version: 1.8
- name: Grant execute permission for gradlew
run: chmod +x gradlew
# - name: Execute jacocoTestReport
# run: ./gradlew test jacocoTestReport && cp build/reports/jacoco/report.xml jacoco.xml || echo "Code coverage failed"
- name: Build with Gradle
run: ./gradlew build --refresh-dependencies --no-daemon --continue
# - name: Push codeCoverage to Codecov
# run: bash <(curl -s https://codecov.io/bash)
- name: Echo credentials
run: echo "bintrayUser=${{secrets.BINTRAY_USER}}" >> gradle.properties
- name: Echo credentials Key
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ git:
services:
- rabbitmq

jdk: openjdk11
jdk: openjdk8

before_cache:
- rm -f $HOME/.gradle/caches/modules-2/modules-2.lock
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
import lombok.extern.java.Log;
import org.reactivecommons.async.impl.communications.ReactiveMessageSender;
import org.reactivecommons.async.impl.communications.TopologyCreator;
import org.reactivecommons.async.impl.converters.json.JacksonMessageConverter;
import org.reactivecommons.async.impl.converters.MessageConverter;
import org.reactivecommons.async.impl.converters.json.JacksonMessageConverter;
import org.reactivecommons.async.impl.converters.json.ObjectMapperSupplier;
import reactor.core.publisher.Mono;
import reactor.core.scheduler.Scheduler;
import reactor.core.scheduler.Schedulers;
import reactor.rabbitmq.*;
import reactor.util.retry.Retry;

import java.time.Duration;
import java.util.logging.Level;
Expand Down Expand Up @@ -68,7 +69,8 @@ Mono<Connection> createSenderConnectionMono(ConnectionFactory factory, String na
.doOnError(err ->
log.log(Level.SEVERE, "Error creating connection to RabbitMq Broker. Starting retry process...", err)
)
.retryBackoff(Long.MAX_VALUE, Duration.ofMillis(300), Duration.ofMillis(3000))
.retryWhen(Retry.backoff(Long.MAX_VALUE, Duration.ofMillis(300))
.maxBackoff(Duration.ofMillis(3000)))
.subscribeOn(senderScheduler)
.cache();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,10 @@
import org.reactivecommons.async.impl.DynamicRegistryImp;
import org.reactivecommons.async.impl.HandlerResolver;
import org.reactivecommons.async.impl.communications.ReactiveMessageListener;
import org.reactivecommons.async.impl.communications.ReactiveMessageSender;
import org.reactivecommons.async.impl.config.props.AsyncProps;
import org.reactivecommons.async.impl.converters.MessageConverter;
import org.reactivecommons.async.impl.listeners.ApplicationCommandListener;
import org.reactivecommons.async.impl.listeners.ApplicationEventListener;
import org.reactivecommons.async.impl.listeners.ApplicationNotificationListener;
import org.reactivecommons.async.impl.listeners.ApplicationQueryListener;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.context.ApplicationContext;
Expand All @@ -43,17 +40,6 @@ public class MessageListenersConfig {
private final AsyncProps asyncProps;


@Bean //TODO: move to own config (QueryListenerConfig)
public ApplicationEventListener eventListener(HandlerResolver resolver, MessageConverter messageConverter,
ReactiveMessageListener receiver, DiscardNotifier discardNotifier) {
final ApplicationEventListener listener = new ApplicationEventListener(receiver,
appName + ".subsEvents", resolver, asyncProps.getDomain().getEvents().getExchange(),
messageConverter, asyncProps.getWithDLQRetry(), asyncProps.getMaxRetries(), asyncProps.getRetryDelay(),
asyncProps.getDomain().getEvents().getMaxLengthBytes(), discardNotifier);
listener.startListener();
return listener;
}

@Bean
public ApplicationNotificationListener eventNotificationListener(HandlerResolver resolver, MessageConverter messageConverter,
ReactiveMessageListener receiver, DiscardNotifier discardNotifier) {
Expand All @@ -68,17 +54,6 @@ public ApplicationNotificationListener eventNotificationListener(HandlerResolver
return listener;
}

@Bean //TODO: move to own config (QueryListenerConfig)
public ApplicationQueryListener queryListener(MessageConverter converter, HandlerResolver resolver,
ReactiveMessageSender sender, ReactiveMessageListener rlistener,
DiscardNotifier discardNotifier) {
final ApplicationQueryListener listener = new ApplicationQueryListener(rlistener,
appName + ".query", resolver, sender, asyncProps.getDirect().getExchange(), converter,
asyncProps.getGlobal().getExchange(), asyncProps.getWithDLQRetry(), asyncProps.getMaxRetries(),
asyncProps.getRetryDelay(), asyncProps.getGlobal().getMaxLengthBytes(), discardNotifier);
listener.startListener();
return listener;
}

@Bean
public ApplicationCommandListener applicationCommandListener(ReactiveMessageListener listener,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import org.reactivecommons.async.impl.communications.ReactiveMessageSender;
import org.reactivecommons.async.impl.config.props.AsyncProps;
import org.reactivecommons.async.impl.converters.MessageConverter;
import org.reactivecommons.async.impl.listeners.ApplicationEventListener;
import org.reactivecommons.async.impl.listeners.ApplicationQueryListener;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Bean;
Expand Down Expand Up @@ -36,4 +37,15 @@ public ApplicationQueryListener queryListener(MessageConverter converter, Handle

return listener;
}

@Bean
public ApplicationEventListener eventListener(HandlerResolver resolver, MessageConverter messageConverter,
ReactiveMessageListener receiver, DiscardNotifier discardNotifier) {
final ApplicationEventListener listener = new ApplicationEventListener(receiver,
appName + ".subsEvents", resolver, asyncProps.getDomain().getEvents().getExchange(),
messageConverter, asyncProps.getWithDLQRetry(), asyncProps.getMaxRetries(), asyncProps.getRetryDelay(),
asyncProps.getDomain().getEvents().getMaxLengthBytes(), discardNotifier);
listener.startListener();
return listener;
}
}