Merge pull request #13 from samkelleher/dont-fail-on-mongodb

fix: Don't totally fail if cannot load MongoDB version.

package.json

@@ -26,6 +26,7 @@
   "sideEffects": false,
   "dependencies": {
     "@reactioncommerce/api-utils": "^1.14.2",
+    "@reactioncommerce/logger": "^1.1.3",
     "@reactioncommerce/reaction-error": "^1.0.1"
   },
   "devDependencies": {

src/queries/systemInformation.js

@@ -1,3 +1,5 @@
+import Logger from "@reactioncommerce/logger";
+
 /**
  * @name queries.systemInformation
  * @method
@@ -12,12 +14,20 @@ export default async function systemInformation(context, shopId) {
 
   await context.validatePermissions(`reaction:legacy:shops:${shopId}`, "read", { shopId });
 
-  const mongoAdmin = await db.admin();
-  const mongoInfo = await mongoAdmin.serverStatus();
+  let mongoVersion = "";
+
+  try {
+    const mongoAdmin = await db.admin();
+    const mongoInfo = await mongoAdmin.serverStatus();
+    mongoVersion = mongoInfo.version;
+  } catch (error) {
+    Logger.error(error);
+  }
+
   const plugins = Object.values(context.app.registeredPlugins).filter((plugin) => plugin.version);
   return {
     apiVersion: context.appVersion,
-    mongoVersion: { version: mongoInfo.version },
+    mongoVersion: { version: mongoVersion },
     plugins: plugins.map(({ name, version }) => ({ name, version }))
   };
 }

src/queries/systemInformation.test.js

@@ -1,7 +1,12 @@
 import mockContext from "@reactioncommerce/api-utils/tests/mockContext.js";
 import ReactionError from "@reactioncommerce/reaction-error";
+import Logger from "@reactioncommerce/logger";
 import systemInformation from "./systemInformation.js";
 
+jest.mock("@reactioncommerce/logger", () => ({
+  error: jest.fn().mockImplementationOnce(() => {})
+}));
+
 const fakeShopId = "FAKE_SHOP_ID";
 mockContext.appVersion = "1.2.3";
 mockContext.validatePermissions = jest.fn("validatePermissions");
@@ -65,3 +70,26 @@ test("returns system info if user has permission", async () => {
 
   return expect(result).toEqual(expectedResult);
 });
+
+test("returns plugins even when mongoVersion fails to load", async () => {
+  const expectedResult = {
+    apiVersion: "1.2.3",
+    mongoVersion: { version: "" },
+    plugins: [
+      { name: "plugin-a", version: "1.0.0" },
+      { name: "plugin-b", version: "1.1.0" },
+      { name: "plugin-c", version: "1.0.2" },
+      { name: "plugin-d", version: "2.0.0" }
+    ]
+  };
+
+  mockContext.validatePermissions.mockReturnValueOnce(Promise.resolve(undefined));
+  mockContext.app.db.admin.mockReturnValueOnce(Promise.resolve(mongoAdmin));
+  mongoAdmin.serverStatus.mockRejectedValueOnce(new Error("Simulate serverStatus() error."));
+  const simulatedError = new Error("Simulate serverStatus() error.");
+
+  const result = await systemInformation(mockContext, fakeShopId);
+
+  expect(result).toEqual(expectedResult);
+  expect(Logger.error).toHaveBeenCalledWith(simulatedError);
+});