Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Deselection of item from the side bar on navigating to the home page. #73

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ARJUN-SABU
Copy link
Contributor

@ARJUN-SABU ARJUN-SABU commented Mar 16, 2021

Say, we click on any component on the sideBar, (say, Header), now, we are directed to the header page and header is selected with a grey coloured selection on the side bar.......
Header_selection

Issue #74 :
Now, if I click on the playground title or the react-native-elements i am redirected to the home page, but, the header was still selected....
Issue

The above issue is solved with this commit
Now, going to the home page, deselects the item from the sideBar

@netlify
Copy link

netlify bot commented Mar 16, 2021

Deploy preview for rne-playground processing.

Building with commit c907456

https://app.netlify.com/sites/rne-playground/deploys/605564adaa6998000766e287

Copy link

@shivambalwani shivambalwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pranshuchittora
Copy link
Member

Pls resolve the conflicts.

@ARJUN-SABU
Copy link
Contributor Author

I am unable to understand why all checks are failing. Any help?

@pranshuchittora
Copy link
Member

Pls pull the new changes and resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants