Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/cross button #104

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

piyushdevOP
Copy link

What kind of change does this PR introduce?

Bug Fix

Did you add tests for your changes?
No.
If relevant, did you update the documentation?
Not Required
Summary
This PR fixes the crossButton bug in Input page. The cross button now clears the input text.
Fixes Issue #70

Does this PR introduce a breaking change?
Not Applicable

Other information

@netlify
Copy link

netlify bot commented Mar 28, 2021

Deploy preview for rne-playground ready!

Built with commit a334386

https://deploy-preview-104--rne-playground.netlify.app

@piyushdevOP
Copy link
Author

Issue #70

crossButtonIssue.mov

Fixed #104

crossButtonFixed.mov

@ARJUN-SABU @ankushdutt @pranshuchittora @Uyadav207 Please look into it. This PR fixes issue #70 .

package.json Outdated
@@ -22,7 +22,8 @@
"react-native-web-linear-gradient": "^1.1.1",
"react-router-dom": "^5.2.0",
"react-scripts": "3.4.1",
"react-view": "^2.3.2"
"react-view": "^2.3.2",
"v8": "^0.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

@@ -57,7 +57,7 @@
<!-- Open Graph / Facebook -->
<meta property="og:type" content="website" />
<meta property="og:url" content="https://react-native-elements.js.org/" />
<meta property="og:title" content="Playground 🚀 | React Native Elements" />
<meta property="og:title" content="Playground | React Native Elements" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pranshu , I will undo this right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants