Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 18.20 for Memory Leak Fix #225

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

TiKevin83
Copy link
Contributor

Updating to Node 18.20 will fix a memory leak regression that has been affecting Jest for a while, see here for references:

jestjs/jest#11956

nodejs/node#51004

@TiKevin83
Copy link
Contributor Author

@cortinico suggestions on the failed circleci build?

@cortinico
Copy link
Member

@cortinico suggestions on the failed circleci build?

The CI failed because the build took more than 1 hour to complete.
In order to merge this we'll have fix the CI by either:

  • Migrating to GitHub Actions
  • Updating the build script to don't attempt to build all the architectures

@cortinico
Copy link
Member

see also #226

@TiKevin83
Copy link
Contributor Author

@cortinico started testing a fix for #226 in #227 - it looks like the publish already has a GitHub actions workflow so it just needed the build half ported

@cortinico
Copy link
Member

@TiKevin83 amazing so can you rebase this PR and we can merge it afterwards 👍

Updating to Node 18.20 will fix a memory leak regression that has been affecting Jest for a while, see here for references:

jestjs/jest#11956

nodejs/node#51004
@TiKevin83
Copy link
Contributor Author

@TiKevin83 amazing so can you rebase this PR and we can merge it afterwards 👍

done - you may also want to remove the CircleCI integration that's still showing up on these PR checks

@cortinico
Copy link
Member

done - you may also want to remove the CircleCI integration that's still showing up on these PR checks

Yeah I already disabled it but for some reason it keep getting re-enabled

@cortinico cortinico merged commit 1209810 into react-native-community:main Jun 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants