Skip to content

Added my own fork of react-native-copilot so that Expo CLI does not keep warning me about it #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Proman4713
Copy link

@Proman4713 Proman4713 commented May 21, 2025

πŸ“ Why & how

Add a new library

βœ… Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json

@Simek
Copy link
Member

Simek commented May 21, 2025

Hey @Proman4713, can you share the screenshot of warning you are wanting to resolve?

@Proman4713
Copy link
Author

image
@Simek i'll also test the other libs and see if they work, then I will add them to the directory if they show no issues!

@Simek
Copy link
Member

Simek commented May 22, 2025

Thanks for sharing! What's the exact command you are executing? Since we do the validation in CLI, in two places, and one more check is also made by expo-doctor.

@Simek
Copy link
Member

Simek commented May 22, 2025

We offer a way to customize the checks and ignore given packages or scopes (usually local one, or private forks), but it might not apply in all cases when the check is performed, hence the question before recommending that approach:

@Proman4713
Copy link
Author

expo doctor

@Proman4713
Copy link
Author

i dont want to exclude these libraries from the directory check, why can't I just properly tell the directory whether or not they work for the new architecture?

@Simek
Copy link
Member

Simek commented May 23, 2025

Usually it's easier to ignore private forks and packages than listing all of the forks of existing libraries. If we would do that, then the directory would be in tens of thousands entries, and the usability of it would be questionable due to shear amount of data, so we need to have some limiting factor.

You initial PR comment suggested directly that your package is not created to be used by others, it's just a fork for your own purpose, and repo stats reflect that. That's why I have suggested excluding the check. If your fork grow, and got some other users usage and traction, there is no reason why it cannot be added later in time.

@Proman4713
Copy link
Author

Alright, you have got a point.. I will manually exclude the fork on my end... But I'll still test the other packages and make PRs for them if they work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants