Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rerender on wrapper height change #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

addictional
Copy link

Fix bug

Behavior :

When height of wrapper change, component doesn't rerender list of items

Related issue on ant/design repo ant-design/ant-design#25960

ezgif com-video-to-gif

@vercel
Copy link

vercel bot commented Aug 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/virtual-list/kz2zixijy
✅ Preview: https://virtual-list-git-fork-addictional-fixer.react-component.vercel.app

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          372       377    +5     
  Branches        96        97    +1     
=========================================
+ Hits           372       377    +5     
Impacted Files Coverage Δ
src/List.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aae9e0...74716b5. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 21, 2020

conflict

@afc163
Copy link
Member

afc163 commented Sep 17, 2024

Conflicting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants