Fix supportRef function for preact #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
20 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 91.51% 91.54% +0.03%
==========================================
Files 38 38
Lines 919 923 +4
Branches 280 284 +4
==========================================
+ Hits 841 845 +4
Misses 76 76
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
@MadCcc 看看这个 |
|
@MadCcc Could you please review this PR? |
|
@MadCcc Bump. |
|
@MadCcc Help! |
|
@afc163 Can you please help get this PR merged? |
|
Could we add test for preact? |
|
Checked for React 16, seems safe to merge. |
zombieJ
approved these changes
Feb 20, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in ant-design/ant-design#44135
Why the issue exists:
The highlighted code in
rc-dropdownreturnstruefor react andfalsefor preacthttps://github.com/react-component/dropdown/blob/master/src/Overlay.tsx#L25
Screenshot
That's why the focus doesn't shift to the menu when using preact.
Now let's take a look at the
supportRefcode and add some console.log to it for debugging:Screenshot
And here are the results:
react
preact
So, based on the screenshots above, we can conclude that in the case of preact, the
nodeOrComponentis afunction, not anobject, so the second condition is fulfilled andfalseis returned.And to fix this I added an additional condition because in the screenshot above you can see that preact as well as react have a
$$typeofproperty equal toSymbol(react.forward_ref)