Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check mouseDownTimeout timer before calling clearTimeout #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shc023
Copy link

@shc023 shc023 commented Jul 31, 2021

this PR boosts performance in our React App, when unmounting a large list containing 10k+ rc-tooltips

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #278 (bd89a0e) into master (55ed22f) will decrease coverage by 0.09%.
The diff coverage is 83.33%.

❗ Current head bd89a0e differs from pull request most recent head b2de5d2. Consider uploading reports for the commit b2de5d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   89.88%   89.79%   -0.10%     
==========================================
  Files          11       11              
  Lines         534      539       +5     
  Branches      136      137       +1     
==========================================
+ Hits          480      484       +4     
- Misses         54       55       +1     
Impacted Files Coverage Δ
src/index.tsx 86.57% <83.33%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ed22f...b2de5d2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant