Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onOptionSelect should check selectedValue is or isn't be null #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buxuku
Copy link

@buxuku buxuku commented Jan 18, 2022

If I press Enter after the input does not match any entries, the component returns a null value and renders an empty component on the page. like:

image

so we should check the selectedValue is null

@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tree-select/J4rpXzTkFJbmtguGKzFdM3kYcMJW
✅ Preview: https://tree-select-git-fork-buxuku-fix-selected-4dc662-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #396 (56bf0d0) into master (8077330) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #396   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          462       462           
  Branches       123       128    +5     
=========================================
  Hits           462       462           
Impacted Files Coverage Δ
src/TreeSelect.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8077330...56bf0d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant