Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: findDOMNode warning #61

Merged
merged 2 commits into from
May 18, 2024
Merged

fix: findDOMNode warning #61

merged 2 commits into from
May 18, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 18, 2024

在 Tour 没有展示之前,不存在 DOM 节点。因而会被降级为 findDOMNode 再次尝试查找。调整逻辑,让其在未渲染阶段跳过整个 Trigger。

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tour ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 5:18am

Copy link

github-actions bot commented May 18, 2024

😭 Deploy PR Preview aa815e8 failed. Build logs

🤖 By surge-preview

@zombieJ zombieJ merged commit 34b326b into master May 18, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nativeElement branch May 18, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant